Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow missing secrets.json, but warn in effect log #467

Open
roberth opened this issue Nov 17, 2022 · 0 comments
Open

Allow missing secrets.json, but warn in effect log #467

roberth opened this issue Nov 17, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@roberth
Copy link
Member

roberth commented Nov 17, 2022

Especially since GitToken, the lack of a secrets.json does not have to be a configuration error.
Nonetheless, we'll want to encourage creation of the file, but not necessarily automate the creation, because that may interfere with some methods of secrets deployment to the agent machine.
Suggested implementation:
Add a warning without the location at the start of the effect log, and a warning with location in the local hercules-ci-agent.service log.

@roberth roberth added the enhancement New feature or request label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant