Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing skipping the installation of the webserver that is not used #663

Open
stof opened this issue Nov 6, 2023 · 1 comment
Open

Comments

@stof
Copy link
Contributor

stof commented Nov 6, 2023

Currently, the buildpack always install both apache and nginx, even though each app will use only one of them, increasing the slug size for nothing. It would be great if the unused one could be skipped during the install.

I see 2 alternatives:

  1. the nice one: automatically detect which server is used based on the commands used in the Procfile
  2. the manual one: allow configuring somewhere (maybe a setting in the extra section in composer.json) which server should be installed (defaulting to install both if this is not configured)
@dzuelke
Copy link
Contributor

dzuelke commented Nov 29, 2023

The issue with approach 1 is that a lot of users have custom startup scripts, compound commands, etc, so there'd always have to be an alternative way.

I too have been thinking about an extra entry, but I am also looking into it for the in-progress PHP CNB, where we can maybe have users control this via project.toml metadata instead (and actually have the web servers supplied by a separate buildpack that gets used automatically but can also be combined with e.g. other language buildpacks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants