Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to keep the panel hidden. #1752

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MagneFire
Copy link

This adds a toggle that allows you to enable/disable the ability to reveal the panel when it's obstructed by windows.

The default behaviour remains unchanged, only an option is added to keep the panel always hidden when it's obstructed by any window. This is particularly useful when someone wants to click on an item at the bottom of the screen in that case the panel will no longer reveal itself.

It partly implements the suggestion provided in this discussion: #1748

Preview:
Screenshot from 2022-09-20 22-14-49

This adds a toggle that allows you to enable/disable the ability to reveal the panel when it's obstructed by windows.

Signed-off-by: Darrel Griët <[email protected]>
@MagneFire MagneFire force-pushed the feature/allow-to-be-revealed branch from 70e5363 to 6a17b2b Compare September 29, 2022 18:59
@MagneFire
Copy link
Author

Here's some more background as to why I decided to implement it as it would appear that the "Require pressure at the edge of the screen to reveal the panel" would solve the ideal solution since it could solve the issue where the panel would appear only when you deliberately want it.

But there's an issue when you have a multiple monitor setup.
Assume the following setup:

  • There are two displays. One stacked above the other.
    • An example of this is a typical laptop + monitor solution.
  • Set dash-to-panel to be visible on the top edge on the bottom display.
  • When the "Require pressure at the edge of the screen to reveal the panel" feature is enabled you will not be able to move the cursor from the bottom display to the top display when you try to move the cursor from the bottom display to the top display as a "barrier" is created preventing the cursor to move across the display.
  • The same issue would occur when you use dash-to-panel on the bottom edge of the top display.

This PR works around some of these inconveniences by adding an option to never show dash-to-panel when it's obstructed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant