-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates for GNOME 47 (gnome-shell 47.beta) #2154
base: master
Are you sure you want to change the base?
Conversation
5ee7b69
to
31f995e
Compare
uses `Cogl.Color` instead of `Clutter.Color``
31f995e
to
0c81f73
Compare
I had to do the same changes after an upgrade to Fedora 41, so I can confirm this is required and works well, as after the changes dash to panel works just fine. |
Could you try to update this patch so that it works with both GNOME Shell 46 and 47? |
I suppose something like: import Clutter from 'gi://Clutter';
import Cogl from 'gi://Cogl';
//...
// TODO: Drop GNOME 46 backwards compatibility
const fallbackColor = Clutter.Color ?
new Clutter.Color({ red: 82, green: 148, blue: 226, alpha: 255 }) :
new Cogl.Color({ red: 82, green: 148, blue: 226, alpha: 255 }); and so on. |
I'm pretty sure that before the Gnome update, there was an "Extensions" item in the panel context menu. But now it's gone. |
@K1nHub, for me, the indicators are displayed correctly. I just manually patched the necessary files based on the diff from this pull request. gnome-shell 1:47.0-1 |
@lufog i patched only 1 file. Which files are patched? |
@K1nHub, just look at the diff in the Files changed tab. |
I applied this patch manually, restarted gnome-shell, and everything is now working just as well as before. |
Built and installed from branch without merging any changes from main. Works on Arch with Gnome 47 👍 |
uses
Cogl.Color
instead ofClutter.Color
as per https://gjs.guide/extensions/upgrading/gnome-shell-47.html#gjsnote: needs further testing:
there is one instance of
new Cogl.Color({...})
that i had to change to aCogl.Color.from_string(...)
inappIcons.js#1053
(in_getRunningIndicatorColor()
) as journalctl logged anthere for some reason.
There are 4 more instances of
new Cogl.Color({...})
that i haven't really tested for:appIcon.js#1135-1136
(in_drawRunningIndicator()
, whentype == DOT_STYLE.METRO
), andprogress.js#408,414
(in_showProgressOverlay()
)