Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for GNOME 47 (gnome-shell 47.beta) #2154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

razielanarki
Copy link

@razielanarki razielanarki commented Aug 11, 2024

uses Cogl.Color instead of Clutter.Color as per https://gjs.guide/extensions/upgrading/gnome-shell-47.html#gjs

note: needs further testing:

there is one instance of new Cogl.Color({...}) that i had to change to a Cogl.Color.from_string(...) in appIcons.js#1053 (in _getRunningIndicatorColor()) as journalctl logged an

JS ERROR: TypeError: (intermediate value).Color is not a constructor

there for some reason.

There are 4 more instances of new Cogl.Color({...}) that i haven't really tested for:

  • 2 in appIcon.js#1135-1136 (in _drawRunningIndicator(), when type == DOT_STYLE.METRO), and
  • 2 in progress.js#408,414 (in _showProgressOverlay())

@razielanarki razielanarki changed the title updates for GNOME 47 (beta) updates for GNOME 47 (gnome-shell 47.beta) Aug 11, 2024
uses `Cogl.Color` instead of `Clutter.Color``
@evfool
Copy link

evfool commented Aug 29, 2024

I had to do the same changes after an upgrade to Fedora 41, so I can confirm this is required and works well, as after the changes dash to panel works just fine.

@jbicha
Copy link

jbicha commented Sep 11, 2024

Could you try to update this patch so that it works with both GNOME Shell 46 and 47?

@lufog
Copy link

lufog commented Sep 12, 2024

I suppose something like:

import Clutter from 'gi://Clutter';
import Cogl from 'gi://Cogl';

//...

// TODO: Drop GNOME 46 backwards compatibility
const fallbackColor = Clutter.Color ?
    new Clutter.Color({ red: 82, green: 148, blue: 226, alpha: 255 }) :
    new Cogl.Color({ red: 82, green: 148, blue: 226, alpha: 255 });

and so on.

@lufog
Copy link

lufog commented Sep 15, 2024

I'm pretty sure that before the Gnome update, there was an "Extensions" item in the panel context menu. But now it's gone.

@K1nHub
Copy link

K1nHub commented Sep 16, 2024

In my case (ubuntu 24) dont show running apps indicator. I can`t see aplication is running or simply pinned to panel
image

@lufog
Copy link

lufog commented Sep 16, 2024

@K1nHub, for me, the indicators are displayed correctly. I just manually patched the necessary files based on the diff from this pull request.

image

gnome-shell 1:47.0-1

@K1nHub
Copy link

K1nHub commented Sep 16, 2024

@lufog i patched only 1 file. Which files are patched?

@lufog
Copy link

lufog commented Sep 16, 2024

@K1nHub, just look at the diff in the Files changed tab.

@netroy
Copy link

netroy commented Sep 20, 2024

I applied this patch manually, restarted gnome-shell, and everything is now working just as well as before.
Thanks 👍🏽

@dstockhammer
Copy link

Built and installed from branch without merging any changes from main. Works on Arch with Gnome 47 👍

@tekstryder
Copy link

v63 was tagged yesterday with Gnome 47 support.

It included 0d14d78, which superseded this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants