-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beautify DTP #2170
base: master
Are you sure you want to change the base?
Beautify DTP #2170
Conversation
- Allow hover animation travel below 0% - Allow hover animation zoom below 100% - Hover highlighting independent of hover animation - Custom color for hover highlighting - Custom color for mouse down highlighting - Icon background with rounded corners - Customize margin for app icons towards screen border and desktop
- Allow hover animation travel below 0% - Allow hover animation zoom below 100% - Hover highlighting independent of hover animation - Custom color for hover highlighting - Custom color for mouse down highlighting - Icon background with rounded corners - Customize margin for app icons towards screen border and desktop
I've made accidentially a rebase instead of a fast-forward merge. This is why all the other commits show up. Merging should not be affected by this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey. I've tried to use your PR locally and found some bugs. Some of them are commented here in review.
Also border radius is not working for hovering and active icons. I'm not sure why.
]; | ||
|
||
if (!this._checkGtkVersion_cssVariables()) { | ||
this._dtpSettingsSignalIds += [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are converting array into string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see your point here. this._dtpSettingsSignalIds
is an array of integers (signal IDs to be precise) and I concatenate two arrays. It may be not the most elegant solution, but I can't see any array-to-string conversion (even implicitly) here.
Please advise
Hey Arilas, The border radius with active icon bug sounds suspicious. May I request your software stack? (so on which distribution of Linux did you test it and what was the version of GNOME?). I am still on Fedora 40 with GNOME 46 and no support for CSS variables. It is possible that my workaround-code for CSS variables works (GNOME <= 46), but my code for the actual implementation (GNOME >= 47) does not. I'll have to look into this. For the other bugs in question, I'll leave a response directly at your code remarks. |
I can confirm that the border radius is not functioning for me. On top of that, neither is selecting a color for the highlight. Even setting it to white, disabling the extension, and/or relogging does not correct that, even though the settings remain the same. My system info is as follows: OS: Arch Linux (rolling) Unfortunately I don't know very well how these things work, so I can't do much on my own to help with debugging. I can provide any information needed by request though. |
Major changes
Some visual impressions with custom settings