enable pulseaudio #193
Merged
enable pulseaudio #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the improvement! Could you please explain that why the uid is hard coded as 1000 in your code? |
That could be improved if I can get the uid of user in the container, but i have no idea how to do that. I think the uid is almost fixed to 1000. Any suggestions? |
|
another commit fixing hard coded uid |
huan
reviewed
Oct 23, 2023
huan
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ALSA might hold the sound device exclusively, which prevents the host from playing any sound. This pull request replaces ALSA with pulseaudio by configuring the container as a client to the pulse server running on the host.