Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] no hard-coding cuda #3270

Merged
merged 3 commits into from
Dec 11, 2024
Merged

[docs] no hard-coding cuda #3270

merged 3 commits into from
Dec 11, 2024

Conversation

faaany
Copy link
Contributor

@faaany faaany commented Dec 2, 2024

What does this PR do?

This PR adds xpu besides cuda and replaces the hard-coded cuda with device-agnostic device.

@muellerzr

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's make this a bit more agnostic as @XuehaiPan recommends :)

docs/source/usage_guides/big_modeling.md Outdated Show resolved Hide resolved
@faaany
Copy link
Contributor Author

faaany commented Dec 6, 2024

Thanks for the suggestion! Code Updated. @muellerzr

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@muellerzr muellerzr merged commit 3e62fbb into huggingface:main Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants