Fix test_eager_matches_sdpa_inference for XPU backend #34889
+48
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds.cuda.sdp_kernel Signed-off-by: Dmitry Rogozhkin <[email protected]>
Currently torch.nn.attention.sdpa_kernel falls back to CPU when torch works with XPU backend. So, cpu thresholds should be used in associated tests. Fixes: huggingface#34888 Signed-off-by: Dmitry Rogozhkin <[email protected]>
…in nemotron Signed-off-by: Dmitry Rogozhkin <[email protected]>
|
Looks like Friday evening is not the best time to run ci. Pushed same code 3 times, seeing different errors on each run:). Not related to the change I think. Will continue on Monday :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included fixes:
torch.nn.attention.sdpa_kernelinstead of deprecatedtorch.backends.cuda.sdp_kerneltorch.amp.autocastinstead of deprecatedtorch.cuda.amp.autocastin nemotrontest_eager_matches_sdpa_inferencetests when running on XPU device since torch.nn.attention.sdpa_kernel falls back to CPU on pytorch XPU backendFixes: #34888
CC: @amyeroberts @ydshieh