Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Autocomplete after the eol command #125

Open
adriens opened this issue Jan 20, 2023 · 6 comments · May be fixed by #216
Open

Feature request: Autocomplete after the eol command #125

adriens opened this issue Jan 20, 2023 · 6 comments · May be fixed by #216
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@adriens
Copy link
Contributor

adriens commented Jan 20, 2023 •
edited
Loading

❔ About

While typing eol+TAB it would be very cool to get the existsing products instead of eol | grep X

🎫 Related content
@adriens adriens changed the title 🙏 Autocomplete after the eol command ❔ 🙏 Feature Requests > Autocomplete after the eol command ❔ Jan 20, 2023
@adriens adriens mentioned this issue Jan 20, 2023
Closed
@adriens adriens changed the title 🙏 Feature Requests > Autocomplete after the eol command ❔ 🙏 Feature Request > Autocomplete after the eol command ❔ Jan 20, 2023
@hugovk
Copy link
Owner

hugovk commented Jan 21, 2023

To do this, whatever controls the tab completion would need to first make an HTTP request first to the https://endoflife.date/docs/api to fetch the list of products. The response could then be cached for a day like we're doing for the usual product EOL responses.

@adriens
Copy link
Contributor Author

adriens commented Jan 22, 2023

Yup, that's the idea 👍

@adriens
Copy link
Contributor Author

adriens commented Jan 22, 2023

with this endpoint : https://endoflife.date/api/all.json

@adriens
Copy link
Contributor Author

adriens commented Feb 2, 2023

Hi guys, any chance to get this feature ❔ 🙏

@hugovk
Copy link
Owner

hugovk commented Feb 2, 2023

I've never had much luck with autocomplete libraries, but would review a PR for this.

@adriens
Copy link
Contributor Author

adriens commented Feb 2, 2023

👌

This was referenced Feb 7, 2023
Closed
Closed
@hugovk hugovk added the enhancement New feature or request label Feb 9, 2023
@hugovk hugovk changed the title 🙏 Feature Request > Autocomplete after the eol command ❔ Feature request: Autocomplete after the eol command Nov 12, 2023
@hugovk hugovk added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 12, 2023
@romainx romainx linked a pull request Jul 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Autocomplete after the eol command romainx/norwegianblue
2 participants
@hugovk @adriens