esc_html is not safe for exception handling in wp-redis

[roborourke]

This is a bug inherited after merging the upstream changes to wp-redis to our fork.

Issues on the pantheon repo:

• Fatal error in WP-CLI when accessing cache pantheon-systems/wp-redis#410
• esc_html is not safe to use (exception loop) pantheon-systems/wp-redis#418

PR merged on upstream repo:

• [CMSP-390] esc_html in trigger_error causes an exception loop pantheon-systems/wp-redis#421

We need to merge the upstream changes again, release and update the cloud module.

If we're not maintaining any of our own changes to the upstream version any more, or if we only forked it to publish to packagist, I would suggest we change Altis to include the upstream as a dependency now that Pantheon have published it https://packagist.org/packages/pantheon-systems/wp-redis

After discussion, it looks like there is no longer any need to keep the HM fork.

Acceptance Criteria

• Remove our forked version and change to upstream
• Test everything still works.
• Archive HM fork

---

For Altis Team Use

Ready for Work Checklist

Is this ticket ready to be worked on? See
the Play Book Definition of Ready

• Is the title clear?
• Is the description clear and detailed enough?
• Are acceptance criteria listed?
• Have any dependencies been identified? (Optional)
• Have any documentation/playbook changes been identified? (Optional)
• Is an estimate or time box assigned?
• Is a priority label assigned?
• Is this ticket added to an epic? (Optional)

Completion Checklist

Is this ticket done? See
the Play Book Definition of Done

• Has the acceptance criteria been met?
• Is the documentation updated (including README)?
• Do any code/documentation changes meet project standards?
• Are automatic tests in place to verify the fix or new functionality?
• Or are manual tests documented (at least on this ticket)?
• Are any Playbook/Handbook pages updated?
• Has a new module release (patch/minor) been created/scheduled?
• Have the appropriate backport labels been added to the PR?

[mikelittle]

I added to refine and must have labels.
We need to check we are ok to switch to the upstream version, or, if we are changing it in some way, incorporate the bug fix.

[mikelittle]

Hey team! Please add your planning poker estimate with Zenhub @ferschubert-hm @jerico @wisyhambolu @kovshenin