Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show dialog on destructive commands #324

Open
dzikowski opened this issue Jun 8, 2022 · 3 comments · May be fixed by #440
Open

Show dialog on destructive commands #324

dzikowski opened this issue Jun 8, 2022 · 3 comments · May be fixed by #440

Comments

@dzikowski
Copy link
Contributor

Fablo allows to call destructive commands on the network: down, prune, recreate etc. They should prompt if use is sure of doing it to avoid unwanted loss of the network state. It should be also allow to bypass the prompt with --silent flag, like ./fablo recreate --silent

@Sanket-0510
Copy link
Contributor

I think I understood the issue, I would like to give it a try!

@Sanket-0510
Copy link
Contributor

Hi @dzikowski I am ready with my code. Is there any way through which I can build the fablo binary through source code and test the commands?

@dzikowski
Copy link
Contributor Author

Yes! You can use ./fablo-build.sh which builds local docker image with fablo distribution, and then use the Fablo script from source code ./fablo.sh init, ./fablo.sh up etc.

Also, once you're done with code changes, you will also need to run npm run test:e2e-update to update our tests, and commit changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants