Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evm t8n support reward -1 #5124

Closed
winsvega opened this issue Feb 22, 2023 · 7 comments
Closed

evm t8n support reward -1 #5124

winsvega opened this issue Feb 22, 2023 · 7 comments

Comments

@winsvega
Copy link

Invalid value for option '--state.reward': cannot convert '-1' to Wei (java.lang.NumberFormatException: Illegal leading minus sign on unsigned string -1.)

state.reward = -1 means to just calculate state hash without coinbase touch or mining rewards to be applied.

@shemnon
Copy link
Contributor

shemnon commented Feb 22, 2023

Where is this documented in the t8n docs?

@winsvega
Copy link
Author

You mean this docs?

https://ethereum-tests.readthedocs.io/en/latest/t8ntool-ref.html

It's not up. We actually doesn't have t8n versioning which we should

@shemnon
Copy link
Contributor

shemnon commented Feb 24, 2023

Would PR #5138 address this? While I can not touch coinbase and not use the default reward, the TX processing will always send fees to the coinbase. Not paying coinbase fees is going to be really hard to unwind.

@winsvega
Copy link
Author

ethereum/tests#1165

@winsvega
Copy link
Author

coinbase fee is paid, it is just 0. if no transactions there is no fee.

@non-fungible-nelson
Copy link
Contributor

Did #5138 complete this issue?

@winsvega
Copy link
Author

Seems to work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants