Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSL self-signed certificate, update cipher suite #984

Merged
merged 5 commits into from
Nov 30, 2024

Conversation

torusrxxx
Copy link
Contributor

Old self-signed certificate generation doesn't always work with Oracle JVM, so I replaced it with the one which use bouncycastle.
Also the node does not try to create a self-signed certificate on start up, because the entropy collection has not yet started when initializing SSL. The self-signed certificate is created when the user turns on SSL.
Finally, SSL cipher suites with weak CBC methods are removed, and SSL cipher suites with AES 256 are added.
In the future, we should allow to import valid SSL certificate and private key.

@bertm
Copy link
Contributor

bertm commented Oct 5, 2024

Old self-signed certificate generation doesn't always work with Oracle JVM

When does it not work? Can we have a unit test for that particular case?

@torusrxxx
Copy link
Contributor Author

Old self-signed certificate generation doesn't always work with Oracle JVM

When does it not work? Can we have a unit test for that particular case?

It's because Oracle doesn't want to let it work in all J2SE run-times. See https://stackoverflow.com/questions/29060064/sun-security-x509-certandkeygen-and-sun-security-pkcs-pkcs10-missing-in-jdk8

@ArneBab ArneBab merged commit 82f2ede into hyphanet:next Nov 30, 2024
1 check passed
@ArneBab
Copy link
Contributor

ArneBab commented Nov 30, 2024

Looks good to me — merged! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants