Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 1.2.0 release #561

Merged
merged 11 commits into from
Aug 14, 2024
Merged

version 1.2.0 release #561

merged 11 commits into from
Aug 14, 2024

Conversation

JessicaS11
Copy link
Member

No description provided.

Copy link

Binder 👈 Launch a binder notebook on this branch for commit c85baec

I will automatically update this comment whenever this PR is modified

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 25 lines in your changes missing coverage. Please review.

Project coverage is 66.05%. Comparing base (102405b) to head (c85baec).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
icepyx/core/variables.py 0.00% 17 Missing ⚠️
icepyx/core/spatial.py 40.00% 0 Missing and 3 partials ⚠️
icepyx/quest/dataset_scripts/argo.py 71.42% 0 Missing and 2 partials ⚠️
icepyx/core/is2ref.py 0.00% 1 Missing ⚠️
icepyx/core/query.py 0.00% 1 Missing ⚠️
icepyx/core/visualization.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
- Coverage   66.27%   66.05%   -0.23%     
==========================================
  Files          36       36              
  Lines        3072     3049      -23     
  Branches      537      537              
==========================================
- Hits         2036     2014      -22     
+ Misses        948      947       -1     
  Partials       88       88              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JessicaS11
Copy link
Member Author

My only mild concern is #562.

@weiji14
Copy link
Member

weiji14 commented Aug 14, 2024

My only mild concern is #562.

So technically, the Publish to PyPI action should be ok when triggered on release because it will be pushing a 1.2.0 tag that doesn't exist on TestPyPI yet 🤞

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JessicaS11
Copy link
Member Author

So technically, the Publish to PyPI action should be ok when triggered on release because it will be pushing a 1.2.0 tag that doesn't exist on TestPyPI yet 🤞

Glad to have this confirmed (that's what I thought). I just have a penchant for ending up with the cases where what should happen isn't what happens... Thanks!

@JessicaS11 JessicaS11 merged commit f2ad0a8 into main Aug 14, 2024
10 of 13 checks passed
@weiji14
Copy link
Member

weiji14 commented Aug 16, 2024

So technically, the Publish to PyPI action should be ok when triggered on release because it will be pushing a 1.2.0 tag that doesn't exist on TestPyPI yet 🤞

Glad to have this confirmed (that's what I thought). I just have a penchant for ending up with the cases where what should happen isn't what happens... Thanks!

Yes, Murphy's law tends to come up during releases (and you and I both know how many times release dramas have happened before), so always good to check!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants