Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address the implications of JSONStream.parse('*') vs JSONStream.parse() #501

Open
browjm4 opened this issue Nov 27, 2024 · 0 comments
Open

Comments

@browjm4
Copy link
Collaborator

browjm4 commented Nov 27, 2024

Bug Description

Using parse('*') parses each object in json individually, meaning anything outside of a json array will not be properly parsed (it will have its keys removed and just read in the values). Playing around with a different option like parse() (which parses the whole json body as one) could alleviate the issue potentially. This could also lead to singular shapes being hashed though which could be problematic

Impact

Could address some underlying issues/frustrations with the type mapper/shape hasher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant