Remove Assertion SyntaxWarning for IES Workshop #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wangcj05 @alfoa I think the failing tests by fixing this assert indicate a more significant problem in FeatureSelection. Previously the assert was being evaluated as a non-empty tuple and missing the second optional argument. So it would always evaluate to true (in python non-empty tuples are truthy) We can either remove this assert or fix the underlying issue. Let me know when these changes can be made and I can close this PR. |
wangcj05
reviewed
Mar 30, 2023
| @@ -64,8 +64,8 @@ def screenAndTrainEstimator(Xreduced, yreduced, estimator, support, params, incl | |||
| @ In, addOnKeys, list, optional, list of additional keys to remove | |||
| @ Out, None | |||
| """ | |||
| assert (not issubclass(estimator.__class__, SupervisedLearning.SupervisedLearning), | |||
| f"estimator class str(estimator.__class__) is not a SupervisedLearning derived class") | |||
| assert not issubclass(estimator.__class__, SupervisedLearning.SupervisedLearning), \ | |||
There was a problem hiding this comment.
I think you should remove "not" from this check. I have checked on my computer, and tests passed. @dylanjm
There was a problem hiding this comment.
Okay, removed not and re-pushed.
wangcj05
approved these changes
Mar 30, 2023
|
Checklist is good. PR can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
#1806
What are the significant changes in functionality due to this change request?
No changes in functionality. Just removes developer level syntax warnings that users don't need to see.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.