-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support react-optimize #1073
Comments
@cia48621793 it wouldn't give Inferno any performance benefit as Inferno's VNodes are not immutable. |
There are plans to make inferno vNodes immutable in v4. |
This will not happen for v4. Moving target forward. |
@Havunen What about immutability of VNode in Inferno 6.0? |
@artemirq If vNode is hoisted and used in one or more places it will be cloned, Im not sure If it gains any performance that way |
@Havunen What you think about future React changes with respect to Inferno? These are:
|
@artemirq
I think this is interesting concept, I have not read enough about it to form opinion yet. I believe async rendering also comes with priority queues or something similar. Pushing everything to event queue wouldn't probably make much sense otherwise. I don't know if managing priority queue is worth the cost of just diffing through, because inferno diff is really fast.
I think we could just add this into Inferno. It should be straightforward unless there is some catch that I'm not aware of. |
@Havunen Hey! Check it out https://twitter.com/reactjs/status/1054886083475857408 React.memo React.Lazy Interesting, for Inferno does need to implement something like React.memo or React.PureComponent? React.Lazy is very interesting with Suspense API ^o^ |
https://github.com/thejameskyle/babel-react-optimize
transform-react-inline-elements would be a little bit problematic for Inferno I guess?
The text was updated successfully, but these errors were encountered: