Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supprot React.forwardRef to HOC components #1381

Closed
aminshoman opened this issue Sep 3, 2018 · 8 comments
Closed

Supprot React.forwardRef to HOC components #1381

aminshoman opened this issue Sep 3, 2018 · 8 comments

Comments

@aminshoman
Copy link

Inferno not supporting React.forwardRef propsed by React 16.3

https://reactjs.org/docs/forwarding-refs.html

@Havunen
Copy link
Member

Havunen commented Sep 3, 2018

Ok, lets add it to v6

@Havunen
Copy link
Member

Havunen commented Sep 3, 2018

done

@aminshoman
Copy link
Author

@Havunen thanks brother,
antther very important features is the rendering errors handeling that was interduced with React 16 as a life-cycle method "componentDidCatch"
https://reactjs.org/blog/2017/07/26/error-handling-in-react-16.html

Do you have this on the next plan? or shall I open a feature request issue?

@Havunen
Copy link
Member

Havunen commented Sep 4, 2018

There is an issue about that already:
#1266

I know some libraries just wrap the diffing in try catch and thats it, but its not actually how React does it, because it can catch event listeners too.

@Havunen
Copy link
Member

Havunen commented Sep 4, 2018

Or maybe we implement it the basic way and document the difference

@trueadm
Copy link
Member

trueadm commented Sep 4, 2018

React doesn’t catch event listeners. It unmounts from the root of a tree does not explicitly catch the exception in a componentDidCatch

@Havunen
Copy link
Member

Havunen commented Sep 4, 2018

Ah okay! Should be doable then

@Havunen
Copy link
Member

Havunen commented Oct 13, 2018

I'm closing this ticket as Inferno v6 is now released! 🎉

https://github.com/infernojs/inferno/releases/tag/v6.0.0

@Havunen Havunen closed this as completed Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants