Passing state with a Router link no longer works with inferno-router 8.0.3

[dessalines]

I also couldn't find any unit tests for state.

Example:

<NavLink
  to={{
    pathname: "/create_post",
    search: "",
    key: "",
    hash: "",
    state: {some: "state here"}
  }}
>a link
</NavLink>

State ends up as null

[Havunen]

Hi,

Thanks for reporting the issue.

Where are you expecting this state to be passed? How was it working previously and what version you were using previously?

[dessalines]

It used to work on 7.2.1 using:

<NavLink
  to={{
    pathname: "/create_post",
    anyStateHere: XXX,
  }}
/>

...

// Access it like this in the other component:
let anyStateHere = this.props.location.state.anyStateHere; 

[Havunen]

Ok thx, I will check

[jhsware]

NavLink has never supported this, however Link has. This isn't a regression bug, but a missing feature. I have created an issue to investigate what changes have been made to react-router so we can port all of them #1614

[jhsware]

According to the docs of the package history you should call history.replace(path, [state]) but we do history.replace(to); loosing the state object.

So what happened is that we bumped the history package from v4 to v5 and lost the fallback from v4 where state and location could be passed in a single object:

1. A URL path or
2. A location-like object with { pathname, search, hash, state }

So we need to unpack the object in Link.ts and change our invocation of history.replace and history.push.

Here is a reference to a react-router commit that I believe addresses the same issue. The commit also contains tests.