Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lang param not working #128

Open
mew22 opened this issue Sep 17, 2018 · 2 comments
Open

Lang param not working #128

mew22 opened this issue Sep 17, 2018 · 2 comments
Labels
api bug needs investigation

Comments

@mew22
Copy link

mew22 commented Sep 17, 2018

I tried to set "fr" on Artist.GetInfoByMbidAsync and Artist.GetInfoAsync but the bio is still in English. I verified on lastfm REST endpoint it works well with &lang=fr.
@rikkit rikkit added this to the 1.1.1 milestone Sep 18, 2018
@rikkit
Copy link
Member

rikkit commented Sep 18, 2018

Thanks for reporting @mew22. I will investigate when I have some spare time (possibly next week).

@klinge
Copy link
Contributor

klinge commented Dec 17, 2018

I had a look at this. Seems like a bug. In the Artist API the method accepts a parameter named bioLang. But then in the SetParameters section in the Artist.GetInfoCommand this is actually never used. This would be easily fixed. I will make the changes and submit a PR.

@klinge klinge mentioned this issue Dec 17, 2018
Closed
@klinge klinge mentioned this issue Dec 27, 2018
Merged
@rikkit rikkit removed this from the 1.1.1 milestone Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api bug needs investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@klinge @rikkit @mew22