Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display column names in MetaCacheExec EXPLAIN output #25582

Closed
Tracked by #25539
hiltontj opened this issue Nov 22, 2024 · 0 comments · Fixed by #25598
Closed
Tracked by #25539

Display column names in MetaCacheExec EXPLAIN output #25582

hiltontj opened this issue Nov 22, 2024 · 0 comments · Fixed by #25598
Assignees
Labels

Comments

@hiltontj
Copy link
Contributor

hiltontj commented Nov 22, 2024

Problem

The MetaCacheExec displays column IDs in the EXPLAIN output. This adds a layer of indirection to operators trying to triage EXPLAIN output since they would need to look up what the column ID refers to. In addition, it is displayed as an integer, which is somewhat confusing given that DataFusion uses integers to refer to column indexes within the table schema.

Proposed solution

Pass forward the Arc<TableDefinition> to the MetaCacheExec so that it can convert the ColumnId in the predicate to a name.

Alternatives

N/A

Additional Context

The MetaCacheFunctionProvider already has a reference to the TableDefinition here:

table_def: Arc<TableDefinition>,

So, this can be passed directly in the TableProvider::scan to the created MetaCacheExec.

See discussion: #25566 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant