OP-107 FHIR service layer #1343
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbmalkovsky
reviewed
Jun 5, 2024
| @@ -0,0 +1,42 @@ | |||
| package org.isf.fhir; | |||
There was a problem hiding this comment.
Thanks for the PR; please add the standard license headers to each file.
|
Hi @Th0rst3nH thanks for the PR! Could you please give some documentation on how it is meant to be used in the rest of the application? |
mwithi
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Should this be under package org.isf.fhir.service ?
|
Yes, this is basically just a simple string json converter to the standard FHIR Message. What kind of documentation do you need? Please see the test how to use it. |
dbmalkovsky
reviewed
Aug 7, 2024
| @@ -0,0 +1,35 @@ | |||
| package org.isf.fhir.service; | |||
There was a problem hiding this comment.
Please add missing license header
dbmalkovsky
reviewed
Aug 7, 2024
| @@ -0,0 +1,35 @@ | |||
| package org.isf.fhir.service; | |||
|
|
|||
| import static org.junit.jupiter.api.Assertions.*; | |||
There was a problem hiding this comment.
Project standards are to enumerate all imports and not use package level wildcards; thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OP-107 Created FHIR Message Layer