New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP-1311 | Create 'oh_settings' table and methods in CORE #1431

Open

SilverD3 wants to merge 22 commits into informatici:develop from SilverD3:OP-1311_move_settings_to_db

Contributor

SilverD3 commented Oct 8, 2024 •

edited by mwithi

Loading

SilverD3 added 2 commits

October 8, 2024 10:45


          new:move settings to database, write methods to manage them and write…

edfafb3

… tests


          Merge branch 'develop' of https://github.com/informatici/openhospital…

3145d2b

…-core into OP-1311_move_settings_to_db

SilverD3 commented

View reviewed changes

sql/step_a111_settings.sql Outdated Show resolved Hide resolved

SilverD3 added 2 commits

October 8, 2024 11:03


          fix:clean code

be6645b


          fix:include sql script to create-all script

d6fc218

mwithi reviewed

View reviewed changes

sql/step_a111_settings.sql Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

sql/step_a111_settings.sql Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

src/main/java/org/isf/settings/manager/SettingManager.java Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

src/main/java/org/isf/settings/model/Setting.java Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

src/main/java/org/isf/settings/model/Setting.java Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

src/main/java/org/isf/settings/service/SettingIoOperationRepository.java Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

src/main/java/org/isf/settings/service/SettingIoOperations.java Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

sql/step_a111_settings.sql Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

sql/step_a111_settings.sql Outdated Show resolved Hide resolved

SilverD3 added 3 commits

October 8, 2024 17:17


          fix:remove deleted column

d12d15b


          chore:remove deleted and editable. Add category and needRestart

7e6e2a1


          Merge branch 'develop' of https://github.com/informatici/openhospital…

6a483aa

…-core into OP-1311_move_settings_to_db

SilverD3 requested a review from mwithi

October 10, 2024 14:40

mwithi reviewed

View reviewed changes

sql/step_a111_settings.sql Outdated Show resolved Hide resolved

SilverD3 added 3 commits

October 11, 2024 09:44


          Merge branch 'develop' of https://github.com/informatici/openhospital…

…-core into OP-1311_move_settings_to_db


          chore:update setting categories

6fc9dcd


          fix:fix setting tests

3e59da4

mwithi reviewed

View reviewed changes

sql/step_04_all_following_steps.sql Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

sql/step_a111_settings.sql Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

sql/step_a111_settings.sql Outdated Show resolved Hide resolved

mwithi reviewed

View reviewed changes

sql/step_a111_settings.sql Outdated Show resolved Hide resolved

SilverD3 added 2 commits

October 11, 2024 11:13


          chore:update load demo data and change enum order

a809448


          fix:fix tests

cab0563

dbmalkovsky reviewed

View reviewed changes

src/main/java/org/isf/settings/manager/SettingManager.java Outdated Show resolved Hide resolved

dbmalkovsky reviewed

View reviewed changes

src/main/java/org/isf/settings/manager/SettingManager.java Outdated Show resolved Hide resolved

dbmalkovsky reviewed

View reviewed changes

src/main/java/org/isf/settings/service/SettingIoOperations.java Outdated Show resolved Hide resolved

dbmalkovsky reviewed

View reviewed changes

src/main/java/org/isf/settings/service/SettingIoOperations.java Outdated Show resolved Hide resolved

SilverD3 added 2 commits

October 14, 2024 08:20


          Merge branch 'develop' of https://github.com/informatici/openhospital…

5d96f09

…-core into OP-1311_move_settings_to_db


          chore:add exception in method signature

c5ce9f7

mwithi added the hold label

Member

mwithi commented Oct 15, 2024

This needs to be tested widely, also taking into account GUI and the application starting scripts, I will do it in the next weeks, but probably will finish in November

Contributor Author

SilverD3 commented Oct 16, 2024

This needs to be tested widely, also taking into account GUI and the application starting scripts, I will do it in the next weeks, but probably will finish in November

Too long . we need this feature to start the integration of ORTHANC

Contributor Author

SilverD3 commented Oct 16, 2024

It will not create a breaking change with the CORE. The CORE rely on GeneralData and ConfigurationProperties to read and write configs. The API will be relying on the database

SilverD3 added 3 commits

October 16, 2024 14:20


          Merge branch 'develop' of https://github.com/informatici/openhospital…

e99938f

…-core into OP-1311_move_settings_to_db


          Merge branch 'develop' of https://github.com/informatici/openhospital…

8b83889

…-core into OP-1311_move_settings_to_db


          Merge branch 'develop' of https://github.com/informatici/openhospital…

1ed967d

…-core into OP-1311_move_settings_to_db

SilverD3 mentioned this pull request

OP-1311 | Create 'oh_settings' controller for CRUD for enabled users informatici/openhospital-api#486

Open

Member

mwithi commented Oct 29, 2024

please resolve conflicts


          Merge branch 'develop' of https://github.com/informatici/openhospital…

170e57a

…-core into OP-1311_move_settings_to_db

Contributor Author

SilverD3 commented Oct 30, 2024

please resolve conflicts

Done!

SilverD3 added 4 commits

November 8, 2024 15:15


          Merge branch 'develop' of https://github.com/informatici/openhospital…

8c787a8

…-core into OP-1311_move_settings_to_db


          Merge branch 'develop' of https://github.com/informatici/openhospital…

c1de136

…-core into OP-1311_move_settings_to_db


          Merge branch 'develop' of https://github.com/informatici/openhospital…

f33e6c6

…-core into OP-1311_move_settings_to_db


          align:rename migration script

c2559a9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold