OH2-443 | Refactor admin forms reset/cancel actions #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilverD3
suggested changes
Dec 6, 2024
There was a problem hiding this comment.
The 'cancel button' could manage at the top level, I mean by the parent component (just like we're doing with the form title). This way, we keep this logic centralize and easy to maintain.
Furthermore, the 'cancel button' actually looks like the button for the 'primary action' of the form, when it's for a secondary or even tertiary action. We could use the secondary color (grey, I think) or a less expressive one.
Finally for the icon, I suggest to use the chevron left or the arrow left
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OH2-443