Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android streaming radios #2

Open
wants to merge 9 commits into
base: Android-StreamingRadios
Choose a base branch
from

Conversation

Abba90
Copy link

@Abba90 Abba90 commented Feb 12, 2015

No description provided.

@bateman
Copy link
Contributor

bateman commented Feb 12, 2015

@Abba90 Please, update the commit comments. They provide ABSOLUTELY no info at the moment.
So, please, amend your commits

@bateman
Copy link
Contributor

bateman commented Feb 13, 2015

For more info on how to structure comments in a PR, please refer to the section "4. Restituire modifiche al progetto sorgente" of the following guide: http://collab.di.uniba.it/tesi-di-laurea/come-sviluppare-un-progetto-di-tesi

@Abba90 Abba90 closed this Feb 13, 2015
estensione progetto android per ascoltare radio online
@bateman bateman reopened this Feb 13, 2015
@bateman
Copy link
Contributor

bateman commented Feb 13, 2015

@Abba90 comments should be in English
Besides, a PR must be closed by your supervisor upon change review. Usually, people do not accept their own PR.

Modifiche  che consentono di usare il server strillone ws al posto di
strillone
modifica riconoscimento url di radio online,pausa con il pulsante
UpperLeft se la radio è in riproduzione, messaggio di inizio buffering
@Abba90 Abba90 force-pushed the Android-StreamingRadios branch from 1611e60 to ea95e06 Compare February 13, 2015 16:08
@Abba90
Copy link
Author

Abba90 commented Feb 13, 2015

Comments are fine now?

@bateman
Copy link
Contributor

bateman commented Feb 13, 2015

Yes, they are! Thank you. But, please, would you also translate code comments from ITA to ENG? See, for example MainActivity.java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants