Add LBT15 to chevron catalog
#793
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All contributors have signed the CLA |
|
I have read the CLA Document and I hereby sign the CLA |
BFalquet
reviewed
Oct 29, 2024
vignettes/chevron_catalog.rmd
Outdated
Comment on lines
810
to
817
| mutate( | ||
| BTOXGRH = as.factor( | ||
| case_when( | ||
| BTOXGR %in% c("-4", "-3", "-2", "-1", "0") ~ "0", | ||
| TRUE ~ BTOXGR | ||
| ) | ||
| ), | ||
| ATOXGRH = as.factor( |
There was a problem hiding this comment.
Nice, but I think you could make use of dunlin::reformat that case:
rr <- rule("0" = c("-4", "-3", "-2", "-1", "0"))
...
mutate(y = reformat(.data$x, rr))
There was a problem hiding this comment.
Thank you so much @BFalquet for the tip! Great advice. I've implemented it in my latest commit. Please let me know if there's anything further I can improve. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #792