Added acceptance tests and docs for the ignore missing schemas flag

acceptance.bats

@@ -105,3 +105,13 @@
   run kubeval fixtures/extra_property.yaml
   [ "$status" -eq 0 ]
 }
+
+@test "Fail when parsing a config with CRD" {
+  run kubeval fixtures/test_crd.yaml
+  [ "$status" -eq 1 ]
+}
+
+@test "Pass when parsing a config with CRD and ignoring missing schemas" {
+  run kubeval --ignore-missing-schemas fixtures/test_crd.yaml
+  [ "$status" -eq 0 ]
+}

docs/index.md

@@ -61,6 +61,19 @@ $ echo $?
 ```
 
 
+## CRDs
+
+Currently kubeval relies on schemas generated from the Kubernetes API. This means it's not
+possible to validate resources using CRDs. Currently you need to pass a flag to ignore
+missing schemas, though this may change in a future major version.
+
+```
+$ kubeval --ignore-missing-schemas fixtures/test_crd.yaml
+Warning: Set to ignore missing schemas
+The document fixtures/test_crd.yaml contains a valid SealedSecret
+```
+
+
 ## Full usage instructions
 
 ```
@@ -73,6 +86,7 @@ Usage:
 Flags:
   -f, --filename string             filename to be displayed when testing manifests read from stdin (default "stdin")
   -h, --help                        help for kubeval
+      --ignore-missing-schemas      Skip validation for resource definitions without a schema
   -v, --kubernetes-version string   Version of Kubernetes to validate against (default "master")
       --openshift                   Use OpenShift schemas instead of upstream Kubernetes
       --schema-location string      Base URL used to download schemas. Can also be specified with the environment variable KUBEVAL_SCHEMA_LOCATION (default "https://raw.githubusercontent.com/garethr")

kubeval/kubeval.go

@@ -156,7 +156,7 @@ func validateResource(data []byte, fileName string, schemaCache map[string]*gojs
 	var spec interface{}
 	result := ValidationResult{}
 	if IgnoreMissingSchemas {
-		log.Warn("Warning: Set to ignore missing schemas!")
+		log.Warn("Warning: Set to ignore missing schemas")
 	}
 	result.FileName = fileName
 	err := yaml.Unmarshal(data, &spec)

kubeval/kubeval_test.go

@@ -89,15 +89,6 @@ func TestStrictCatchesAdditionalErrors(t *testing.T) {
 	}
 }
 
-func TestSkipCrdSchemaMiss(t *testing.T) {
-	IgnoreMissingSchemas = true
-	filePath, _ := filepath.Abs("../fixtures/test_crd.yaml")
-	fileContents, _ := ioutil.ReadFile(filePath)
-	results, _ := Validate(fileContents, "test_crd.yaml")
-	if len(results[0].Errors) != 0 {
-		t.Errorf("For custom CRD's with schema missing we should skip with SkipCrdSchemaMiss flag")
-	}
-}
 
 func TestValidateMultipleVersions(t *testing.T) {
 	Strict = true
@@ -170,3 +161,14 @@ func TestDetermineKind(t *testing.T) {
 		t.Errorf("Shouldn't be able to find a kind when passed a blank string")
 	}
 }
+
+func TestSkipCrdSchemaMiss(t *testing.T) {
+	IgnoreMissingSchemas = true
+	filePath, _ := filepath.Abs("../fixtures/test_crd.yaml")
+	fileContents, _ := ioutil.ReadFile(filePath)
+	results, _ := Validate(fileContents, "test_crd.yaml")
+	if len(results[0].Errors) != 0 {
+		t.Errorf("For custom CRD's with schema missing we should skip with SkipCrdSchemaMiss flag")
+	}
+}
+