Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PciHostBridgeFdtDxe: factor out ECAM-specific portions into lib #103

Open
andreiw opened this issue Mar 5, 2024 · 0 comments
Open

PciHostBridgeFdtDxe: factor out ECAM-specific portions into lib #103

andreiw opened this issue Mar 5, 2024 · 0 comments

Comments

@andreiw
Copy link
Contributor

andreiw commented Mar 5, 2024

Will be necessary to use this driver on non-ecam platforms. This basically should be an init/fini pair + function to read/write a config space register. Also add a VOID *Context to _PCI_ROOT_BRIDGE_INSTANCE so the lib can maintain extra state if needed.

All state manipulated by init/fini/cfg accessors should be pushed into a common struct, i.e.:

  UINT32                                              Segment;
  EFI_DT_REG                                          ConfigReg;
  UINT64                                              Attributes;
  UINT64                                              Supports;
  EFI_DT_RANGE                                        BusRange;
  EFI_DT_RANGE                                        IoRange;
  EFI_DT_RANGE                                        MemRange;
  EFI_DT_RANGE                                        PMemRange;
  EFI_DT_RANGE                                        MemAbove4GRange;
  EFI_DT_RANGE                                        PMemAbove4GRange;
  BOOLEAN                                             DmaAbove4G;
  BOOLEAN                                             NoExtendedConfigSpace;

Originally posted by @andreiw in #12 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant