Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent overprompting for permission and account #243

Merged
merged 7 commits into from
Nov 12, 2024

Conversation

gjsjohnmurray
Copy link
Collaborator

This PR fixes #242

@gjsjohnmurray
Copy link
Collaborator Author

gjsjohnmurray commented Nov 12, 2024

Steps required before merge and release:

  • Bump ./types/package.json to 3.8.0
  • From ./types run npm publish --tag latest --access public to publish @intersystems-community/intersystems-servermanager
  • Update ./package.json devDependencies to use this

@gjsjohnmurray
Copy link
Collaborator Author

@isc-bsaviano please install this VSIX to verify that Server Manager continues working as normal but without the recently-appearing superfluous re-prompting for permission and for account.

That behaviour will continue in the ObjectScript extension and others using our authentication provider until we publish 3.8, they require it, and they tweak their calls (see updated README info).

@isc-bsaviano
Copy link
Contributor

@gjsjohnmurray I don't use the auth provider in my regular workflows. What's the best workflow to test this?

@gjsjohnmurray
Copy link
Collaborator Author

I assume your intersystems.servers entries contain passwords alongside usernames. Please remove the password from one or more entries, then expand those servers to discover their namespaces. When prompted for a password, type it in and click the key icon on the input title. Then restart VS Code and re-expand those servers. Prior to this PR you would get reprompted to give permission and to confirm which account to use.

@gjsjohnmurray
Copy link
Collaborator Author

Pinging @isc-rsingh in case you are interested in trying this.

Also @isc-tleavitt since you and your team may have been impacted by the recent increase in prompting which this aims to address.

Please note though that the ObjectScript and Language Server extensions will continue to overprompt until this PR is merged and adopted.

@isc-bsaviano
Copy link
Contributor

@gjsjohnmurray The new VSIX seems fine to me. It works as intended, but since I don't use this on a day-to-day basis I've never experienced the problem that it's trying to solve.

@gjsjohnmurray gjsjohnmurray marked this pull request as ready for review November 12, 2024 20:52
@gjsjohnmurray gjsjohnmurray marked this pull request as draft November 12, 2024 20:57
@gjsjohnmurray gjsjohnmurray marked this pull request as ready for review November 12, 2024 21:03
@gjsjohnmurray gjsjohnmurray merged commit f8969ca into intersystems-community:master Nov 12, 2024
5 checks passed
@gjsjohnmurray gjsjohnmurray deleted the fix-242 branch November 12, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent VS Code change has resulted in more frequent user account quickpicks
3 participants