-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent overprompting for permission and account #243
Prevent overprompting for permission and account #243
Conversation
Steps required before merge and release:
|
@isc-bsaviano please install this VSIX to verify that Server Manager continues working as normal but without the recently-appearing superfluous re-prompting for permission and for account. That behaviour will continue in the ObjectScript extension and others using our authentication provider until we publish 3.8, they require it, and they tweak their calls (see updated README info). |
@gjsjohnmurray I don't use the auth provider in my regular workflows. What's the best workflow to test this? |
I assume your |
Pinging @isc-rsingh in case you are interested in trying this. Also @isc-tleavitt since you and your team may have been impacted by the recent increase in prompting which this aims to address. Please note though that the ObjectScript and Language Server extensions will continue to overprompt until this PR is merged and adopted. |
@gjsjohnmurray The new VSIX seems fine to me. It works as intended, but since I don't use this on a day-to-day basis I've never experienced the problem that it's trying to solve. |
This PR fixes #242