Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBViewer: Add mode to add manually multiple loop closures without optimizing graph right away #1376

Open
matlabbe opened this issue Nov 5, 2024 · 0 comments

Comments

@matlabbe
Copy link
Member

matlabbe commented Nov 5, 2024

Related to #1368

If the graph is huge, it is tedious to add manually loop closures to fix some parts of the map when the graph is optimized after each "add" and it takes a lot more than 5 sec. The graph also re-zooms on the full map so we loose track of the current section we are looking at. It could be nice to disable auto-optimization after each action modifying the graph so that we can do many edits before doing the long optimization.

Note that the auto-optimization when adding loop closures is there to be able to detect bad loop closures. We could disable auto-optimization only if RGBD/OptimizeMaxError is 0 (which re-optimization doesn't matter as the check won't be done).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant