Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concise layout #1381

Merged
merged 5 commits into from
Nov 16, 2024
Merged

Concise layout #1381

merged 5 commits into from
Nov 16, 2024

Conversation

Nosille
Copy link
Contributor

@Nosille Nosille commented Nov 13, 2024

I run multiple cameras and as a result frequently want the images and graph in database viewer to be bigger. These changes enable a mode that hides parts of the interface to make that true.

@matlabbe
Copy link
Member

matlabbe commented Nov 14, 2024

Are changes in PreferencesDialog needed? It seems only DatabaseViewer needs to be updated.

@Nosille
Copy link
Contributor Author

Nosille commented Nov 15, 2024

I used VerticalLayout as a template, and it included definitions in the PreferencesDialog. I assume that without the entries in PreferencesDialog it will not save the configuration between sessions. I will see what happens when I remove it and get back to you.

@matlabbe
Copy link
Member

matlabbe commented Nov 15, 2024

The config in Preferences affects the layout under MainWindow. The config in DatabaseViewer is saved on its own. EDIT: the vertical layout option is also used in MainWindow, that's why it appears two times.

@matlabbe
Copy link
Member

I tested it and we don't need the changes from Preferences to save/reload the config. I removed those changes. I updated the PR to not draw matching lines and to be able to click on graph view's nodes to always change graphics view A.

Thanks for the PR, I like this view mode.

@matlabbe matlabbe merged commit f10dee4 into introlab:master Nov 16, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants