Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the number of datastructures #25

Open
rofinn opened this issue Mar 17, 2021 · 1 comment
Open

Reduce the number of datastructures #25

rofinn opened this issue Mar 17, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rofinn
Copy link
Member

rofinn commented Mar 17, 2021

Currently, our container types includes the following:

  • OrderedSets
  • LittleDicts
  • Tuples
  • Patterns
  • KeyedArrays / NamedDimsArray

This can make it hard to follow what operations will return what data types, so maybe we can simplify this in someway.
At the very least, we should probably try to minimize how much of this is exposed through the documentation and avoid too many examples of how they interact with other packages like Tables.jl, DataFrames.jl, etc.
@rofinn rofinn added enhancement New feature or request help wanted Extra attention is needed labels Mar 17, 2021
@rofinn rofinn mentioned this issue Mar 17, 2021
Open
@rofinn
Copy link
Member Author

rofinn commented Mar 24, 2021 •
edited
Loading

I wonder if restricting XArray to KeyedArray(NamedDimsArray(...)) would help as it would simplify some of the type signatures printed to the REPL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rofinn