Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC/CTD check conflict #60

Open
jcermauwedu opened this issue May 23, 2024 · 0 comments
Open

QC/CTD check conflict #60

jcermauwedu opened this issue May 23, 2024 · 0 comments

Comments

@jcermauwedu
Copy link

Related to #58. We need to check datasets that have not had any QC checks (QARTOD) flags, but we still want the checker to check for anything else in the specs. However, if you disable the qc checks, the CTD checks still flag QC type attributes.

Example:

$ compliance-checker -t gliderdac:3.0 -s check_qc_variables /home/portal/glider/process/unit_507/20240512/gutils/rt/netcdf/unit_507_1715633718_20240513T205518Z_rt.nc
Running Compliance Checker on the datasets from: ['/home/portal/glider/process/unit_507/20240512/gutils/rt/netcdf/unit_507_1715633718_20240513T205518Z_rt.nc']


--------------------------------------------------------------------------------
                         IOOS Compliance Checker Report                         
                          Version 5.1.2.dev30+gf543e4f                          
                     Report generated 2024-05-23T11:29:23Z                      
                                 gliderdac:3.0                                  
   https://ioos.github.io/glider-dac/ngdac-netcdf-file-format-version-2.html    
--------------------------------------------------------------------------------
                               Corrective Actions                               
unit_507_1715633718_20240513T205518Z_rt.nc has 3 potential issues


                                    Required                                    
--------------------------------------------------------------------------------
CTD Variables
* Variable temperature must contain attribute: ancillary_variables
* Variable conductivity must contain attribute: ancillary_variables
* Variable salinity must contain attribute: ancillary_variables
* Variable density must contain attribute: ancillary_variables

Depth/Pressure variable attributes
* Variable pressure must contain attribute: ancillary_variables
* Variable depth must contain attribute: ancillary_variables

Lat and Lon attributes
* Variable lat must contain attribute: ancillary_variables
* Variable lon must contain attribute: ancillary_variables

That is why I introduced the -O gliderdac:no_ancillary_variables to the gliderdac plugin to skip checks for the ancillary_variables attribute.

When the QC check is disabled, the ctd_variables check pulls that attribute back in via hardcoded definitions (cc_plugin_glider/required_var_attrs.py).

    "lat": {
        "standard_name": "latitude",
        "units": "degrees_north",
        "_FillValue": None,
        "ancillary_variables": None,
        "comment": None,
        "coordinate_reference_frame": None,
        "long_name": None,
        "observation_type": None,
        "platform": None,
        "reference": None,
        "valid_max": None,
        "valid_min": None,
    },

So, we want the CTD check to continue, but not with the QC parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant