Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address challenges encountered in implementing the QC test on the data arrays #318

Open
leilabbb opened this issue Feb 6, 2024 · 4 comments
Assignees
Labels

Comments

@leilabbb
Copy link
Contributor

leilabbb commented Feb 6, 2024

This issue was created based on findings from working on #277

The QC process needs additional conditional statements to handle special cases of data arrays. The following have been already identified and are being tested:

Test 1:
Check the time array for data start time inconsistent with the deployment start time, invalid timestamps, duplicate timestamps, and non-ascending timestamps
Action 1:
The QC tests are skipped and the Global attribute dac_qc_comment is annotated with test 1 results.

Test 2:
Check the legacy variable for an empty array, an array with all fill values, or nans
Action 2:
The QC tests are skipped and the Global attribute dac_qc_comment is annotated with test 2 results.

Test 3:
Check the legacy variables' standard names for non-CF compliant names
Action 3:
The QC tests are skipped and the Global attribute dac_qc_comment is annotated with test 3 results.

Test 4:
Check the legacy variables for the missing attribute "ancillary_variables"
Action 4:
The QC tests are not skipped and the "ancillary_variables" is created

Test 5:
Check variables sharing the same standard name as the legacy variables
Action 5:
The QC tests are skipped and the Global attribute dac_qc_comment is annotated with test 5 results.

@leilabbb leilabbb added the QC label Feb 6, 2024
@leilabbb leilabbb self-assigned this Feb 6, 2024
@leilabbb leilabbb changed the title address challenges encountered in implementing the QC test on the data arrays #144 address challenges encountered in implementing the QC test on the data arrays Feb 6, 2024
@leilabbb
Copy link
Contributor Author

leilabbb commented Feb 14, 2024

Remark: Need a consistent way to parse the deployment start time to complete test 1.
Parsing the deployment name using the specified date/time convention (YYYYmmddTHHMM) defined in the deployment registration guideline.

@leilabbb
Copy link
Contributor Author

The following tests have been completed:

  • [ x] Test 1: Check the time array
  • [ x] Test 2: Check the legacy variables
  • [ x] Test 3: Check the attribute "standard_name"
  • [ x] Test 4: Check the attribute "ancillary_variables"
  • [x ] Test 5: Check shared "standard_name" attributes

@leilabbb leilabbb reopened this Aug 23, 2024
@leilabbb
Copy link
Contributor Author

The following test need to be added:

  • Test 6:

Include non-zero timestamps that are invalid in the timestamps check.
Action 1:
The QC tests are skipped and the Global attribute dac_qc_comment is annotated with test 6 results.

@sarinamann-noaa
Copy link

@leilabbb will verify the last test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants