-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve repo size labels and explanation #1248
Comments
I'd go with B or C: we really need an explainer for these values. @ericronne small clarification: value behind |
Do we have a panel design? If not, I’ll handle... |
I dont think this is a bug. It maybe confusing and need some UI adjust but behavior is correct. |
I personally like the B approach but would prefer a pattern of tooltip over numbers for more information. @juliaxbow what do you think? |
Mind this issue was created in 2019 and these designs no longer reflect current UI or the way ecosystem and use cases evolved. For reference, my understanding of the current state (2024-11-14) is:
Honestly, it is not that bad. Most users will not see first number being bigger than the second one, unless they manually imported a big DAG from IPFS, and did not preload it yet. Perhaps the fix is simpler than one discussed in 2019? We could add a note at the end of "Files" explanation, that it is ok if this number is higher than the second one, and leave it as is. See proposed fix in #2295 👉 In the future, we could detect if we are in a directory that is not fully local, we could split the first item into "Local Files" and "Remote Files" sizes, but that requires either hacking with But for now, I would not over-complicate this UI, and do #2295 instead. |
MFS can store files in "lazy" fashion, which means root is added to MFS, but children are fetched lazily, on first use.
Example
English wikipedia mirror is ~650 GB. Lazy pointer to it can be added to MFS instantly via:
$ ipfs files cp /ipfs/QmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco /en.wikipedia-on-ipfs.org
Problem
This feature of MFS creates a problem in WebUI, it looks like "Files" take more space than "entire repo":
This will become a problem when we start taking advantage of this lazy mode in website cohosting (discussed in ipfs-shipyard/cohosting#6)
Solution?
We need to change the labels, make them more informative.
Below is a quick mock that illustrates what additional information needs to be conveyed.
The problem is that it does not look good, and we need to clean this up somehow.
Thoughts?
The text was updated successfully, but these errors were encountered: