-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report] convert_mesh.py
failed when *.obj
file name starts with a number
#1287
Closed
2 tasks done
Comments
This was referenced Oct 22, 2024
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this issue
Nov 21, 2024
…isaac-sim#1302) # Description Fixes isaac-sim#1287 **Issue details**: When using the convert_mesh.py script to convert .obj to .usd, if the obj file in this scene starts with a number(0c334eaabb844eaaad049cbbb2e0a4f2.obj), while the USD API prohibits names that start with a number [Link](https://openusd.org/release/api/group__group__tf___string.html#gaa129b294af3f68d01477d430b70d40c8). This issue is described in more detail here: [Link](https://forums.developer.nvidia.com/t/cant-create-prims-if-name-starts-with-number/249617). Also deleted useless debugging output code. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
adrian-sch
pushed a commit
to adrian-sch/IsaacLab
that referenced
this issue
Dec 6, 2024
…isaac-sim#1302) # Description Fixes isaac-sim#1287 **Issue details**: When using the convert_mesh.py script to convert .obj to .usd, if the obj file in this scene starts with a number(0c334eaabb844eaaad049cbbb2e0a4f2.obj), while the USD API prohibits names that start with a number [Link](https://openusd.org/release/api/group__group__tf___string.html#gaa129b294af3f68d01477d430b70d40c8). This issue is described in more detail here: [Link](https://forums.developer.nvidia.com/t/cant-create-prims-if-name-starts-with-number/249617). Also deleted useless debugging output code. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When using the
convert_mesh.py
script to convert.obj
to.usd
, if the obj file in this scene starts with a number(0c334eaabb844eaaad049cbbb2e0a4f2.obj
), while the USD API prohibits names that start with a number Link. This issue is described in more detail here: Link.Perhaps we should modify the
_convert_asset()
function inconvert_mesh.py
script to throw a user-friendly warning when themesh_file_basename
does not comply with the USD file format.This issue was first encountered in leggedrobotics/viplanner#32 (comment)
Checklist
The text was updated successfully, but these errors were encountered: