clean(ZMS-2375): made title of websites distinctive

[msfb3]

Description

Short description or comments

Reference

Issues #XXX

Summary by CodeRabbit

• New Features

  • Updated webpage titles for various templates to simplify branding, changing from "Zeitmanagementsystem" to "ZMS" or "ZMS Statistik".

• Bug Fixes

  • Adjusted the expected output in tests to reflect the new title "Kategorie auswählen" in the rendering process.

• Chores

  • Maintained overall layout and structure across templates without additional modifications.

[coderabbitai]

Walkthrough

This pull request includes updates to multiple Twig template files and a PHP class, primarily focusing on changing the title elements displayed in the browser. The title strings have been simplified from "Zeitmanagementsystem" to "ZMS" or "ZMS Statistik" in various templates. Additionally, the WarehouseIndex class has an updated title in the readResponse method, and corresponding tests have been adjusted to reflect this change. Overall, the modifications are limited to title updates without altering the underlying structure or functionality.

Changes

File Path	Change Summary
zmsadmin/custom_templates/block/layout/main.twig	Changed title from {{ title }} - Zeitmanagementsystem to {{ title }} - ZMS.
zmsadmin/custom_templates/layout/main.twig	Changed title from {{ title }} - Zeitmanagementsystem to {{ title }} - ZMS.
zmsadmin/templates/block/layout copy/main.twig	Changed title from {{ title }} - Zeitmanagementsystem to {{ title }} - ZMS.
zmsadmin/templates/block/layout/main.twig	Changed title from {{ title }} - Zeitmanagementsystem to {{ title }} - ZMS.
zmsadmin/templates/layout/fullwidth.twig	Changed title from {{ title }} - Zeitmanagementsystem to {{ title }} - ZMS.
zmsadmin/templates/layout/main.twig	Changed title from {{ title }} - Zeitmanagementsystem to {{ title }} - ZMS.
zmsstatistic/custom_templates/layout/main.twig	Changed title from "Zeitmanagementsystem" to "ZMS Statistik".
zmsstatistic/templates/layout/fullwidth.twig	Changed title from {{ title }} - Zeitmanagementsystem to {{ title }} - ZMS Statistik.
zmsstatistic/templates/layout/main.twig	Changed title from "Zeitmanagementsystem" to "ZMS Statistik".
zmsstatistic/src/Zmsstatistic/WarehouseIndex.php	Updated 'title' in readResponse from 'Übersicht verfügbarer Kategorien' to 'Kategorie auswählen'.
zmsstatistic/tests/Zmsstatistic/WarehouseIndexTest.php	Updated test assertion to check for 'Kategorie auswählen' instead of 'Übersicht verfügbarer Kategorien'.

Possibly related PRs

• feat(ZMS-3401): new calldisplay layout desk #714: The changes in this PR involve modifications to the title element in the default.twig template, similar to the title changes made in the main PR for the various template files.

Suggested reviewers

• Fabinatix97

🐰 In the land of code, where titles reside,
A change was made, with joy and pride.
From long names to short, we hopped with glee,
Now "ZMS" shines bright, as bright as can be!
With templates refreshed, our work is done,
A simpler title, oh what fun! 🌟

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between f850db5 and 5d5446f.

⛔ Files ignored due to path filters (1)

• zmscalldisplay/package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (1)

• zmscalldisplay/package.json (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• zmscalldisplay/package.json

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

zmsadmin/templates/block/layout copy/main.twig (1)

Line range hint 1-100: Review template organization strategy

The presence of a "layout copy" directory suggests potential technical debt. Consider:

1. Documenting why this copy exists
2. Merging templates if possible
3. Using template inheritance instead of copies

Consider implementing a more maintainable template structure:

• Use Twig template inheritance with blocks for variations
• Create a base layout template with common elements
• Use configuration parameters for site-specific values like titles

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 25b8597 and 96b160d.

📒 Files selected for processing (16)

• zmsadmin/custom_templates/block/layout/main.twig (1 hunks)
• zmsadmin/custom_templates/layout/main.twig (1 hunks)
• zmsadmin/src/Zmsadmin/Application.php (1 hunks)
• zmsadmin/templates/block/layout copy/main.twig (1 hunks)
• zmsadmin/templates/block/layout/main.twig (1 hunks)
• zmsadmin/templates/block/page/index.twig (1 hunks)
• zmsadmin/templates/layout/fullwidth.twig (1 hunks)
• zmsadmin/templates/layout/main.twig (1 hunks)
• zmsadmin/templates/page/index.twig (1 hunks)
• zmsadmin/templates/page/logout.twig (1 hunks)
• zmsadmin/templates/page/workstationSelect.twig (1 hunks)
• zmsstatistic/custom_templates/exception/bo/layout.twig (1 hunks)
• zmsstatistic/custom_templates/layout/main.twig (1 hunks)
• zmsstatistic/templates/exception/bo/layout.twig (1 hunks)
• zmsstatistic/templates/layout/fullwidth.twig (1 hunks)
• zmsstatistic/templates/layout/main.twig (1 hunks)

✅ Files skipped from review due to trivial changes (12)

• zmsadmin/templates/page/workstationSelect.twig
• zmsadmin/custom_templates/block/layout/main.twig
• zmsadmin/templates/block/layout/main.twig
• zmsstatistic/templates/layout/fullwidth.twig
• zmsadmin/custom_templates/layout/main.twig
• zmsstatistic/custom_templates/layout/main.twig
• zmsadmin/templates/layout/fullwidth.twig
• zmsstatistic/templates/layout/main.twig
• zmsadmin/templates/page/index.twig
• zmsstatistic/custom_templates/exception/bo/layout.twig
• zmsadmin/templates/block/page/index.twig
• zmsstatistic/templates/exception/bo/layout.twig

🔇 Additional comments (3)

zmsadmin/templates/page/logout.twig (1)

13-13: LGTM: Consistent branding update

The site name change from "Zeitmanagementsystem" to "Zmsadmin" aligns with the PR's objective to make website titles more distinctive and is consistent with similar changes across other templates.

zmsadmin/templates/layout/main.twig (1)

14-14: Consider SEO and user experience implications of abbreviated title

While "ZMS" makes the title more concise, consider the following points:

1. New users might not immediately understand what "ZMS" stands for
2. Search engines might give less weight to abbreviated titles
3. Consider adding a more descriptive <meta name="description"> tag to compensate

zmsadmin/templates/block/layout copy/main.twig (1)

14-14: ⚠️ Potential issue

Address title inconsistency and clarify template purpose

The title suffix "Zmsadmin" differs from "ZMS" used in other templates, which could lead to inconsistent branding. Additionally:

1. The purpose of this copy template is unclear
2. Having duplicate layout files could lead to maintenance issues
3. Consider consolidating templates or clearly documenting their distinct purposes

Consider standardizing to either "ZMS" or "Zmsadmin" across all templates for consistency.