You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
to compile full profile API, jakarta.facesand jakarta.mail implementation classes are required
xml.binding-api is multi-release jar file but versioned class is missing from the platform-api artifact
javadoc footer contains hardcoded 2018, 2020 copyright years - the latter should reflect the year when the javadoc is built (so for 9.1 release 2021 should have been there) - this can be automated ie through build-helper-maven-plugin:timestamp-property
OSGi headers are missing - not sure they are wanted/needed and/or required; projects being built by Eclipse Tycho may benefit from them
The text was updated successfully, but these errors were encountered:
Great ideas, @lukasj! Thanks! Some of them were known improvements, and some are easier said than done (ie. implementation class dependencies). If you (or anybody else) wants to take a shot at resolving any of these via a PR or two, I'd be very happy to help review and get them merged. Thanks!
@arjantijms can you help here by addressing issues in JSTL and Faces APIs?
the rest should not be difficult.
It would be nice if in the end EE 10 provides platform level javadoc looking like the one SE platform has, including the list of modules (with one tab for web profile, other for full profile and eventually also one for core profile...) - not sure we'll get there but it might be good to see the motivation behind these changes...
Looking at how the API artifacts are built and what exactly they contain I see following issues:
xml.binding-api
(see Remove dependency on XML Binding from the API pom tags#149)jakarta.faces
implementation classes are required (see In javax/faces/FactoryFinder.java, remove references to com.sun.faces.spi eclipse-ee4j/glassfish#19861 (comment)) - this may become a problem when/if one decides to put built API artifact on the module path for multiple reasons depending on particular command line configuration (ie non-exported package from implementation; split package problem)jakarta.faces
andimplementation classes are requiredjakarta.mail
xml.binding-api
is multi-release jar file but versioned class is missing from theplatform-api
artifact2018, 2020
copyright years - the latter should reflect the year when the javadoc is built (so for 9.1 release 2021 should have been there) - this can be automated ie throughbuild-helper-maven-plugin:timestamp-property
The text was updated successfully, but these errors were encountered: