Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build of API artifacts #108

Open
lukasj opened this issue Jul 9, 2021 · 2 comments
Open

Improve build of API artifacts #108

lukasj opened this issue Jul 9, 2021 · 2 comments

Comments

@lukasj
Copy link
Contributor

lukasj commented Jul 9, 2021

Looking at how the API artifacts are built and what exactly they contain I see following issues:

  • web profile artifact transitively depends on xml.binding-api (see Remove dependency on XML Binding from the API pom tags#149)
  • to compile web profile API, jakarta.faces implementation classes are required (see In javax/faces/FactoryFinder.java, remove references to com.sun.faces.spi eclipse-ee4j/glassfish#19861 (comment)) - this may become a problem when/if one decides to put built API artifact on the module path for multiple reasons depending on particular command line configuration (ie non-exported package from implementation; split package problem)
  • to compile full profile API, jakarta.faces and jakarta.mail implementation classes are required
  • xml.binding-api is multi-release jar file but versioned class is missing from the platform-api artifact
  • javadoc footer contains hardcoded 2018, 2020 copyright years - the latter should reflect the year when the javadoc is built (so for 9.1 release 2021 should have been there) - this can be automated ie through build-helper-maven-plugin:timestamp-property
  • OSGi headers are missing - not sure they are wanted/needed and/or required; projects being built by Eclipse Tycho may benefit from them
@kwsutter
Copy link
Contributor

Great ideas, @lukasj! Thanks! Some of them were known improvements, and some are easier said than done (ie. implementation class dependencies). If you (or anybody else) wants to take a shot at resolving any of these via a PR or two, I'd be very happy to help review and get them merged. Thanks!

@lukasj
Copy link
Contributor Author

lukasj commented Jul 14, 2021

changes in mail are in progress already (see https://github.com/eclipse-ee4j/mail/projects/1)

@arjantijms can you help here by addressing issues in JSTL and Faces APIs?

the rest should not be difficult.

It would be nice if in the end EE 10 provides platform level javadoc looking like the one SE platform has, including the list of modules (with one tab for web profile, other for full profile and eventually also one for core profile...) - not sure we'll get there but it might be good to see the motivation behind these changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants