Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Persistence TCK to Persistence Project? #1350

Open
arjantijms opened this issue Jul 9, 2024 · 3 comments
Open

Move Persistence TCK to Persistence Project? #1350

arjantijms opened this issue Jul 9, 2024 · 3 comments

Comments

@arjantijms
Copy link
Contributor

It seems there is a standalone TCK, proboably the one here: https://github.com/jakartaee/platform-tck/tree/tckrefactor/jpa

It somehow made it into this release https://download.eclipse.org/jakartaee/persistence/3.2/jakarta-persistence-tck-3.2.0.zip but it's not super clear where that one exactly came from.

Might be a lot easier for both tracking and consistency to move this to the https://github.com/jakartaee/persistence project.

@scottmarlow @lukasj

@gurunrao
Copy link
Contributor

gurunrao commented Jul 9, 2024

It seems there is a standalone TCK, proboably the one here: https://github.com/jakartaee/platform-tck/tree/tckrefactor/jpa

It somehow made it into this release https://download.eclipse.org/jakartaee/persistence/3.2/jakarta-persistence-tck-3.2.0.zip but it's not super clear where that one exactly came from.

Might be a lot easier for both tracking and consistency to move this to the https://github.com/jakartaee/persistence project.

@scottmarlow @lukasj

https://github.com/jakartaee/platform-tck/tree/tckrefactor/jpa - is the source for https://download.eclipse.org/jakartaee/persistence/3.2/jakarta-persistence-tck-3.2.0.zip
There is an overlap of Platform TCK tests and JPA Specification tests. Platform TCK team is in the process of implementing Vehicles/Protocol for refactored code. Post completion of Vehicles with refactored code and ability to run Specification tests within vehicles as required by Platform TCK, we should be able to move Persistence Specification tests to https://github.com/jakartaee/persistence

@arjantijms
Copy link
Contributor Author

Thanks! There wasn't a tag created, or was there? So we don't know what exact version corresponds to the 3.2.0 release?

@scottmarlow
Copy link
Contributor

Thanks! There wasn't a tag created, or was there? So we don't know what exact version corresponds to the 3.2.0 release?

We should definitely tag the commit used for doing the 3.2.0 release for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants