Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

TypeConverter #12

Open
davidlund opened this issue Oct 24, 2014 · 1 comment
Open

TypeConverter #12

davidlund opened this issue Oct 24, 2014 · 1 comment

Comments

@davidlund
Copy link

Hi James,

Rather than implementing your own TypeConversion and hence adding dependencies onto Joda you should be able to hook into ConfigurableBeanFactory.getTypeConverter() (within your ReloadablePropertyPostProcessor - making it BeanFactoryAware) and use springs TypeConverter leaving it more extensible and you'd be able to chop a load of code! I've not tested this, but cant think why it wouldn't work.

Also suggest making your logback dependencies test scope for those log4j{2} users

@jamesmorgan
Copy link
Owner

Alright dave, hope your well. Thanks for the tips, I've only just seen your comment. I however am unlikely to make many changes to this as I haven't used in a while. Feel free to open a PR if you like :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants