Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Incorrect check on Path #9

Open
vincentmonier opened this issue Jul 17, 2014 · 1 comment
Open

Incorrect check on Path #9

vincentmonier opened this issue Jul 17, 2014 · 1 comment

Comments

@vincentmonier
Copy link

In class PropertiesWatcher method pathMatchResources does not always work.
indeed it uses Path.getFileName().toString() method to compare with resource. But toString method does not always returns file name as expected, depending on OS and JDK version.

it's a better approach to use equals method.

    private boolean pathMatchesResource(final Path target, final Resource resource) {
         //at this point target cannot be null
         return Paths.get(resource.getFilename()).equals(target);
    }

of course this method works only for file resources.

@jamesmorgan
Copy link
Owner

👍 Cheers, on a PR with and tests which are needed and I will merge it in. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants