draw-frame vs full-refresh

[patrickbkr]

TW::Input.draw-frame calls self.full-refresh while TW::SpanBuffer.full-refresh calls self.draw-frame. This feels inconsistent.

[japhb]

Oh yes, agreed that this is a mess, and a known one at that. It came from merging two different designs that I had for how to optimize relayouts and redraws while still supporting the basic Terminal-Print animation model. I'd already done some cleanup of this (the easy bits mostly), so what you see now isn't quite as bad as it once was, but this all needs some sit-down-and-design time.

FWIW the reason this is not trivial to design is that there's a complex interaction of the above goals with Z layering, popovers, and partially-transparent layers that needs to be thought through thoroughly (sorry, couldn't resist that phrasing 😉).

[patrickbkr]

Simply removing Input.draw-frame worked. (I did that so I could make my RichText do both Input and SpanBuffer, both of which provided a draw-frame.)