Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _.VERSION to the documentation #2998

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

Aurimas-stack
Copy link
Contributor

Added _.VERSION as per #2992 issue.

In my opinion placing it under Notes should be more than enough as utility section seems to include more complex methods than this one.

version

Copy link
Collaborator

@jgonggrijp jgonggrijp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making a contribution. @Aurimas-stack!

Please put this in the Utility section and also add it to the table of contents so that people can find it by typing. The Notes section is for comments about the semantics of functions that apply to more than one function.

I have a few nitpicks as well, see below. Otherthan that, I am content.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@Aurimas-stack
Copy link
Contributor Author

Hey @jgonggrijp ,

I've made the requested changes, please review them, cheers.

Copy link
Collaborator

@jgonggrijp jgonggrijp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And congratulations with your first contribution!

@jgonggrijp jgonggrijp linked an issue Oct 16, 2024 that may be closed by this pull request
@jgonggrijp jgonggrijp merged commit 0d820ef into jashkenas:master Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention _.VERSION in the documentation
2 participants