-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a Free Transform option #552
base: master
Are you sure you want to change the base?
Conversation
…e part of the key)
scaled ratios, or dimensions for resizing
…e ALWAYS returns 'size': None
Could use a 2nd eye on this. Adding an option changed the key used for caching (since the key is partially made by options supplied), so I updated the paths for the tests. |
Can't the change of keys be avoided somehow? A change would be quite bad for big sites with lots of images. |
That's a good point. I guess it could go in with the I'll make the changes accordingly. |
Conflicts need fixing |
Ensuring resolved conflicts still work, set to WIP |
@kckaiwei are we ready to merge this? |
No, I actually forgot about this tbh, I don't work at the same place that used it last time, so lemme see if I can get a test running for this, iirc. I had a bunch of failing tests on Travis last time due to it that I couldn't figure out. |
Thanks. Take a look and let us know. If you think there is no way to get this up and running we better close this PR |
For those times when you do not want/need scaling with image ratio (for one reason or another). This option will forcibly rescale/stretch the image to the supplied dimensions.