Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine grained state and propagation #2

Open
baranowb opened this issue Sep 25, 2020 · 0 comments
Open

Fine grained state and propagation #2

baranowb opened this issue Sep 25, 2020 · 0 comments

Comments

@baranowb
Copy link
Contributor

Right now FSM of BisectablePullRequest is one that drives CRYO. Its a bit fragile and aggressive( state propagates up and down the tree if case of error) - its simple and effective but not very good.
This should be refined to compartmentalize state to single BPR( rather than tree). Secondly there should be a way to access this from roots, since roots is what CRYO operate on( tree is recursive).
Second issue is a bit of child of first one. If something goes wrong in tree of BPR we get whole tree with agressive state change, which tells us nothing to pinpoint fault( unless you go through logs, which is less than ideal).

So:

  1. Refine state of BPR
  2. Refine how its accessed from roots
  3. Improve fault report either with some steps or just via above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant