Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automated check for code-style for pull requests. #30

Open
fazer1929 opened this issue Mar 10, 2022 · 3 comments
Open

automated check for code-style for pull requests. #30

fazer1929 opened this issue Mar 10, 2022 · 3 comments

Comments

@fazer1929
Copy link
Contributor

Right now there is no mechanism to check for code style while merging PR's, which can result in merging BAD code. To avoid this, perhaps a Github Action can be set which does this checks
@rpelisse
Copy link

rpelisse commented Mar 10, 2022 •
edited
Loading

@fazer1929 Can you set that up? Maybe do a PR for that? Maybe also do that for other repos like Harmonia, Zeus, Cedalion and so on, if possible?

@fazer1929
Copy link
Contributor Author

sure, I will
Also should the action just include running maven tests or something else too?

@rpelisse
Copy link

If it's possible, definitely!

fazer1929 added a commit to fazer1929/cryo that referenced this issue Mar 10, 2022
@fazer1929
Issue jboss-set#30: Github action to run maven checks on push/PR.
d3c0a4a
fazer1929 added a commit to fazer1929/cryo that referenced this issue Mar 10, 2022
@fazer1929
Issue jboss-set#30: Github action to run maven checks on push/PR.
689257b
fazer1929 added a commit to fazer1929/cryo that referenced this issue Mar 11, 2022
@fazer1929
Issue jboss-set#30: Github action to run maven checks on push/PR.
4f3ce7a
baranowb added a commit that referenced this issue May 13, 2022
@baranowb
Merge pull request #31 from fazer1929/githubAction
52c0721 
Issue #30: Github action to run maven checks on push/PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rpelisse @fazer1929