Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H2Data does not support COLUMNS with ".", "-", or digits #28

Closed
pinaf opened this issue Jan 22, 2015 · 23 comments
Closed

H2Data does not support COLUMNS with ".", "-", or digits #28

pinaf opened this issue Jan 22, 2015 · 23 comments

Comments

@pinaf
Copy link

pinaf commented Jan 22, 2015

Fix for issue #7 only dealt with table names. The same Base32 encoding should be done for column names. This is needed for yegor/s3auth#90

@dmarkov
Copy link

dmarkov commented Jan 22, 2015

this task will get someone's attention soon

@dmarkov
Copy link

dmarkov commented Jan 22, 2015

@pinaf many thanks for the bug report, I added 15 mins to your acc, transaction AP-3LH50245RL416922R

@pinaf
Copy link
Author

pinaf commented Jan 22, 2015

@dmarkov thank you

@dmarkov
Copy link

dmarkov commented Jan 27, 2015

@apocarteres the task is yours

apocarteres pushed a commit to apocarteres/jcabi-dynamo that referenced this issue Jan 31, 2015
@apocarteres
Copy link

@dmarkov i have added test to prove the issue, also added puzzle there. Please find someone to work on that puzzle.

@apocarteres
Copy link

@yegor256 what do you think about PR with test and puzzle for this issue? I think it's out of issue's scope to make a decision should H2Data support mentioned functionality or not, moreover to add/remove such functionality.

@pinaf
Copy link
Author

pinaf commented Jan 31, 2015

@apocarteres We need class H2Data to support such functionality - it currently does not. If you look at issue #7 you'll see the solution was to use Base32 encoding. However #7 only did this for table names. In this issue we need it for column names also.

@apocarteres
Copy link

@pinaf i see, let me discuss it with Yegor, please

@apocarteres
Copy link

@dmarkov it's needed more time here

@pinaf
Copy link
Author

pinaf commented Feb 5, 2015

@apocarteres any progress?

@dmarkov
Copy link

dmarkov commented Feb 6, 2015

@dmarkov it's needed more time here

@apocarteres agreed, take your time

@apocarteres
Copy link

@pinaf waiting for @yegor256 comments

@yegor256
Copy link
Member

yegor256 commented Feb 6, 2015

@apocarteres sure, reproducing a problem is a good solution. check this article: http://www.yegor256.com/2015/01/15/how-to-cut-corners.html

@apocarteres
Copy link

@yegor256 ok thanks
@pinaf well, i have created PR with test to prove that H2Data doesn't support such symbols you mentioned above. Also the puzzle created with ask to implement such functions if they should be implemented. In terms of this task we confirmed (by test) the fact of missing some functions and the next step is guys make new task to solve the puzzle and add requested features then.

apocarteres pushed a commit to apocarteres/jcabi-dynamo that referenced this issue Feb 6, 2015
@pinaf
Copy link
Author

pinaf commented Feb 6, 2015

@apocarteres ok, let's get it to pass the code review :)

apocarteres pushed a commit to apocarteres/jcabi-dynamo that referenced this issue Feb 6, 2015
apocarteres pushed a commit to apocarteres/jcabi-dynamo that referenced this issue Feb 7, 2015
rultor added a commit that referenced this issue Feb 8, 2015
@apocarteres
Copy link

@pinaf test added and merged. please check

@pinaf
Copy link
Author

pinaf commented Feb 8, 2015

@apocarteres thanks!

@pinaf pinaf closed this as completed Feb 8, 2015
@dmarkov
Copy link

dmarkov commented Feb 10, 2015

@apocarteres 30 mins was added to your account, many thanks for your contribution!; +30 to your rating, your total score is +255

@longtimeago
Copy link

@yegor256 looks like we need to release new version of jcabi-dynamo to proceed with yegor256/s3auth#90

@pinaf
Copy link
Author

pinaf commented Feb 10, 2015

@longtimeago also the functionality isn't there yet.

@longtimeago
Copy link

@pinaf ahr .... still blocked :(

@0pdd
Copy link

0pdd commented Jul 13, 2022

@pinaf the puzzle #unknown is still not solved.

@0pdd
Copy link

0pdd commented Sep 23, 2022

@pinaf the only puzzle #97 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants