Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression fix for rc.postlocal #2449

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

Baxxy13
Copy link
Contributor

@Baxxy13 Baxxy13 commented Sep 27, 2023

Description

  • fixes a regression between etc/config/safemode and /usr/local/etc/rc.postlocal
  • now, rc.postlocal should no longer executed if we are in safemode

Related Issue

#2447 (comment)

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Alternate Designs

Possible Drawbacks

If we are booting in safemode and S99SetupLEDs isn't starting correctly, then etc/config/safemode will not be removed.

Verification Process

Implemented this change on my RaspberryMatic Testsystem and booted in Safemode and Normalmode.
Execution of /usr/local/etc/rc.postlocal will now correctly suppressed if the system boots in Safemode.

Release Notes

Regression fix for rc.postlocal which now prevents correctly the execution in safemode.

Contributing checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING and LICENSE document.
  • I fully agree to distribute my changes under Apache 2.0 license.

- fixes a regression between etc/config/safemode and /usr/local/etc/rc.postlocal
- now, rc.postlocal should no longer executed if we are in safemode
@jens-maus jens-maus added 🐛 bug-report Something isn't working 🧠 unstable-snapshot This ticket references the use of an unsupported unstable snapshot being used. labels Sep 27, 2023
@jens-maus jens-maus added this to the next release milestone Sep 27, 2023
@jens-maus jens-maus merged commit 22c3f01 into jens-maus:master Sep 27, 2023
6 checks passed
@Baxxy13 Baxxy13 deleted the regression_fix_rc_postlocal branch September 27, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug-report Something isn't working 🧠 unstable-snapshot This ticket references the use of an unsupported unstable snapshot being used.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants