fixes #1513 #2513
Merged
fixes #1513 #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jens-maus
added
🐛 bug-report
jp112sdl
added a commit
to jp112sdl/RaspberryMatic
that referenced
this pull request
Nov 18, 2023
…into dev_patch0182_fix1513 * 'master' of https://github.com/jens-maus/RaspberryMatic: snapshot bump [3.73.9.20231118-bf6c11c] Add port 2110 for homeputer Exec-Engine to HA-addon config (jens-maus#2515, @tomquist) updated OCCU to 3.73.9-1 and adapted WebUI patches. explicitly disable the bcm283x serial driver support in the rpi versions of u-boot so that they won't interfere with our rpi-rf-mode dtbo. This should allow to remove the stdout-path workaround to prevent u-boot from crashing in case the rpi-rf-mod.dtbo is enabled in config.txt. (cf. home-assistant/operating-system#2919) snapshot bump [3.73.6.20231117-d250419] added new WebUI 0182-WebUI-Fix-DimmerControl-RemoveButtonRefreshDelay patch which fixes unwanted delay in displaying the correct dimmer status (jens-maus#1513, jens-maus#2513, @jp112sdl)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After creating the dimmer controls, a refresh method sets the correct css style (by setting certain classes) for the ON and OFF buttons. This is done with a timeout of 1 second and leads to a strange optical behaviour as described in the related issue.
Setting this timeout to zero fixes it.
Related Issue
#1513
Types of changes
Alternate Designs
Possible Drawbacks
Only tested with
HM-LC-Dim1TPBU-FMandHM-LC-Dim1T-FMVerification Process
Release Notes
Contributing checklist