You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
buildEffektRelease as we have it is very restrictive, it cannot fathom the idea of a different source of the release than GitHub.
That's not entirely correct, we can also get the .tar.gz NPM package from NPM itself or from a custom build.
Therefore it might make sense to split buildEffektRelease into:
buildEffektNPM: takes a NPM package as a source and builds it (that's most of what buildEffektRelease does right now)
a thin wrapper buildEffektGitHubRelease (with a temp deprecated alias buildEffektRelease) which takes a version and hash, gets the .tar.gz file from GitHub Releases and calls buildEffektNPM
Feel free to come up with better / more idiomatic names.
The text was updated successfully, but these errors were encountered:
jiribenes
changed the title
Split buildEffektRelease into buildEffektNPM and buildEffektGitHubRelease
Split buildEffektRelease into building an NPM package and building a GitHub release
Sep 12, 2024
buildEffektRelease
as we have it is very restrictive, it cannot fathom the idea of a different source of the release than GitHub.That's not entirely correct, we can also get the
.tar.gz
NPM package from NPM itself or from a custom build.Therefore it might make sense to split
buildEffektRelease
into:buildEffektNPM
: takes a NPM package as a source and builds it (that's most of whatbuildEffektRelease
does right now)buildEffektGitHubRelease
(with a temp deprecated aliasbuildEffektRelease
) which takes a version and hash, gets the.tar.gz
file from GitHub Releases and callsbuildEffektNPM
Feel free to come up with better / more idiomatic names.
The text was updated successfully, but these errors were encountered: