Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split buildEffektRelease into building an NPM package and building a GitHub release #12

Open
jiribenes opened this issue Sep 12, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jiribenes
Copy link
Owner

buildEffektRelease as we have it is very restrictive, it cannot fathom the idea of a different source of the release than GitHub.
That's not entirely correct, we can also get the .tar.gz NPM package from NPM itself or from a custom build.

Therefore it might make sense to split buildEffektRelease into:

  1. buildEffektNPM: takes a NPM package as a source and builds it (that's most of what buildEffektRelease does right now)
  2. a thin wrapper buildEffektGitHubRelease (with a temp deprecated alias buildEffektRelease) which takes a version and hash, gets the .tar.gz file from GitHub Releases and calls buildEffektNPM

Feel free to come up with better / more idiomatic names.

@jiribenes jiribenes added enhancement New feature or request good first issue Good for newcomers labels Sep 12, 2024
@jiribenes jiribenes changed the title Split buildEffektRelease into buildEffektNPM and buildEffektGitHubRelease Split buildEffektRelease into building an NPM package and building a GitHub release Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant